Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug fixes and race conditions #424

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

pallabmaiti
Copy link
Contributor

Description

Miscellaneous bug fixes and race conditions fixed.

@pallabmaiti pallabmaiti self-assigned this Dec 14, 2023
@pallabmaiti pallabmaiti marked this pull request as ready for review December 15, 2023 04:45
@pallabmaiti pallabmaiti requested a review from itsdebs as a code owner December 15, 2023 04:45
@pallabmaiti pallabmaiti force-pushed the feature/sdk-861-fix-race-conditions branch from 80591c3 to e979231 Compare December 15, 2023 04:50
@pallabmaiti pallabmaiti force-pushed the feature/sdk-861-fix-race-conditions branch from 461ba0b to 809b407 Compare December 15, 2023 06:49
Copy link

@pallabmaiti pallabmaiti added the v2 label Jan 8, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Application Opened event we are getting build and version as properties.
In v1, these properties were part of the Application Installed and Application Updated events.
Can we consider making behaviour same as v1 i.e., remove build and version from properties in the Application Opened event for all the platforms?

@pallabmaiti pallabmaiti changed the base branch from develop-v2 to develop-v3 January 17, 2024 06:40
@pallabmaiti pallabmaiti merged commit c235391 into develop-v3 Jan 17, 2024
9 checks passed
@pallabmaiti pallabmaiti deleted the feature/sdk-861-fix-race-conditions branch January 30, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants