Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update lastActiveTimestamp value when reset call is made #412

Merged
merged 6 commits into from
Nov 9, 2023
Merged

fix: update lastActiveTimestamp value when reset call is made #412

merged 6 commits into from
Nov 9, 2023

Conversation

1abhishekpandey
Copy link
Contributor

Description

  • Refactor variable and method name: LastEventTimeStamp to LastActiveTimestamp.
  • Fix: Update the last active timestamp value when the RESET call is made. This will prevent the SDK from generating a new sessionId, when the app is relaunched following a force close after a RESET call has been made. (Note: This fix might be temporary and we can decide to change it based on further discussion.)
  • Updated the SDK init snippet for the Objc-c sample app.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.0% 70.0% Coverage
0.0% 0.0% Duplication

@1abhishekpandey 1abhishekpandey merged commit 6f229ad into develop Nov 9, 2023
9 checks passed
@1abhishekpandey 1abhishekpandey deleted the fix/sdk-561-fix-clear-of-sessionid-when-reset-call-is-made branch November 9, 2023 07:25
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desusai7 desusai7 desusai7 approved these changes

@ChryssaAliferi ChryssaAliferi ChryssaAliferi approved these changes

@pallabmaiti pallabmaiti Awaiting requested review from pallabmaiti

@itsdebs itsdebs Awaiting requested review from itsdebs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1abhishekpandey @ChryssaAliferi @desusai7