Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove PageMessage and PAGE event type #455

Open
wants to merge 1 commit into
base: feat/android
Choose a base branch
from
Open

feat: remove PageMessage and PAGE event type #455

wants to merge 1 commit into from

Conversation

ChryssaAliferi
Copy link
Contributor

Ticket

Description

In this PR, we remove the page event public API from the Android SDK. Page is not supported in the mobile SDKs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Implementation Details

  • Removes the code that relates with the page event
  • Removes the relevant tests

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@ChryssaAliferi ChryssaAliferi requested a review from a team July 1, 2024 09:15
@ChryssaAliferi ChryssaAliferi self-assigned this Jul 1, 2024
@ChryssaAliferi ChryssaAliferi requested a review from itsdebs as a code owner July 1, 2024 09:15
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdebs itsdebs Awaiting requested review from itsdebs

Assignees

@ChryssaAliferi ChryssaAliferi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ChryssaAliferi