Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from sqlcipher legacy to latest version #419

Merged
merged 2 commits into from
May 20, 2024

Conversation

itsdebs
Copy link
Contributor

@itsdebs itsdebs commented Apr 16, 2024

Fixes # (issue)
SDK-1495
fix: #413

why

SQL Cipher legacy version is deprecated.

This migration requires user to change the sqlcipher dependency
Screenshot 2024-04-16 at 5 30 22 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ChryssaAliferi
ChryssaAliferi previously approved these changes Apr 17, 2024
Copy link
Contributor

@ChryssaAliferi ChryssaAliferi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from me. However, It would be nice if we could have updated
implementation "androidx.sqlite:sqlite:2.3.1" to 2.4.0 which is the latest version as we are testing this feature.

@itsdebs itsdebs added the v1 label May 20, 2024
@itsdebs itsdebs dismissed stale reviews from ChryssaAliferi and 1abhishekpandey via 51da080 May 20, 2024 04:59
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@itsdebs itsdebs merged commit a739a78 into develop May 20, 2024
9 checks passed
@itsdebs itsdebs deleted the feature/sdk-1495-replace-cipher-dependency branch May 20, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android-database-sqlcipher has been deprecated in favour of sqlcipher-android
3 participants