Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added persistence support for advertisingId and api to clear advertisingId #406

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

desusai7
Copy link
Contributor

feat: added persistence support for advertisingId and added a new api to clear advertisingId

  • Added support for persisting advertisingId, so the advertisingId would be attached to all the events made on subsequent app launches.
  • Added clearAdvertisingId() API on RudderClient to clear the persisted advertisingId. This is an instance method and can be called only after SDK initialization.
  • If the putAdvertisingId() API is called when the auto collection of advertisingId is enabled, the advertisingId passed by the API is considered, and the auto collection of advertisingId is disabled.
  • Auto collection of advertising ID is enabled back only when the manually set advertising Id is cleared by calling the clearAdvertisementId() API.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

itsdebs
itsdebs previously approved these changes Mar 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@desusai7 desusai7 added the v1 label Mar 19, 2024
@desusai7 desusai7 merged commit b1d7905 into develop Mar 19, 2024
10 checks passed
@desusai7 desusai7 deleted the feature/sdk-1412-android branch March 19, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants