Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed serialization of strings twice #390

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented Feb 6, 2024

fixed serialization of strings twice

  • When a String is serialized again using Gson, it is converted into a format which cannot be de-serialized back by Gson, fixed this by not serializing a String in the places where it is needed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@desusai7 desusai7 marked this pull request as ready for review February 6, 2024 17:44
saikumarrs
saikumarrs previously approved these changes Feb 7, 2024
@desusai7 desusai7 self-assigned this Feb 7, 2024
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@desusai7 desusai7 merged commit 4bc1d7d into develop Feb 7, 2024
7 checks passed
@desusai7 desusai7 deleted the fix/double_serialization_of_strings branch February 7, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants