Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: table not found in database. added locks #326

Merged
merged 2 commits into from
Oct 3, 2023
Merged

fix: table not found in database. added locks #326

merged 2 commits into from
Oct 3, 2023

Conversation

itsdebs
Copy link
Contributor

@itsdebs itsdebs commented Sep 27, 2023

Fixes # (issue)
fixed race conditions

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@itsdebs itsdebs requested a review from desusai7 September 27, 2023 06:29
desusai7
desusai7 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@desusai7 desusai7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lot of blocks of code which were commented and few debug statements, can we please remove them ?

@itsdebs
chore: removed comments and logs
ef1f2fb 
Signed-off-by: Debanjan Chatterjee <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@itsdebs itsdebs merged commit 1b5e670 into develop-v2 Oct 3, 2023
5 checks passed
@itsdebs itsdebs deleted the fix/sdk-623-1.19.0-sqlite-exception-table-not-found branch October 3, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desusai7 desusai7 desusai7 approved these changes

@pallabmaiti pallabmaiti Awaiting requested review from pallabmaiti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsdebs @desusai7