Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable audience for trino rETL #995

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

ashishRudder
Copy link
Contributor

@ashishRudder ashishRudder commented Oct 18, 2023

Description of the change

enable audience for trino rETL

Part of REV-362

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (509555d) 100.00% compared to head (63f111e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #995   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashishRudder ashishRudder merged commit 1e0acb4 into develop Oct 18, 2023
@ashishRudder ashishRudder deleted the trino-audience branch October 18, 2023 13:17
@linear
Copy link

linear bot commented Oct 19, 2023

REV-362 Release trino audience via integrations-config

Problem

Proposed Work

Acceptance Criteria

Docs

Estimate (Weeks):

Pair: None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants