Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new destination tiktok_audience #964

Merged
merged 13 commits into from
Nov 2, 2023
Merged

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Oct 4, 2023

Description of the change

Resolves INT-755 & INT-467
We are adding one new destination named Tiktok Audience

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@linear
Copy link

linear bot commented Oct 4, 2023

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6344ce) 100.00% compared to head (8b8316a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop      #964   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ItsSudip ItsSudip requested a review from koladilip October 27, 2023 06:19
…ntegrations-config into feat.tiktok_audience
Copy link

linear bot commented Nov 2, 2023

INT-467 rETL Audience: TikTok

Slack thread: https://rudderlabs.slack.com/archives/C02AAM3QE82/p1692278469641109?thread_ts=1692278469.641109&cid=C02AAM3QE82
Message by: shamil
Feature Request by: Achutha Sourabh Chellapilla

@mihir-4116 mihir-4116 merged commit 6c5ac5f into develop Nov 2, 2023
5 checks passed
@ItsSudip ItsSudip deleted the feat.tiktok_audience branch December 13, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants