Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate mixpanel apiSecret #1304

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Apr 3, 2024

What are the changes introduced in this PR?

Deprecating the API secret support, As this setting is not required anymore for authentication.
Related : rudderlabs/rudder-transformer#2833

What is the related Linear task?

Resolves INT-652

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new checks got introduced or modified in test suites. Please explain the changes.

N/A


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • I have executed schemaGenerator tests and updated schema if needed

  • Are sensitive fields marked as secret in definition config?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

Copy link

linear bot commented Apr 3, 2024

INT-652 Mixpanel Cloud Mode: Deprecate the support for /track endpoint

Reviewers: sudip , shrouti

RudderStack is supporting mixpanel /track and /import endpoint for sending the events.

Mixpanel suggest to use /import endpoint for server side integration, As it is more scalable as compared to /track endpoint.

/track /import
Events per request 50 2000
Authentication Project Token, intended for untrusted clients. Project Secret, intended for server-side integration.Update: Project Token is also supported now
Compression None Gzip allowed
Content-Type application/x-www-form-urlencoded application/json or application/x-ndjson
Ingesting historical events Last 5 days only. Any time after 1971-01-01.

Both track and import APIs are synchronous in nature. It update the data in mixpanel in realtime.

References of the requirement (Slack/Notion/PRD doc)

Not a customer requirement, Marking this a new feature to make the integration more reliable, increase batching efficiency.




  • The Slack link for the respective thread is attached.
  • Docs card attached.
  • GitHub PR is attached to the task.
  • Release label attached to the task.
  • The project associated with the task is linked, if any.
  • Document the monitoring steps here

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e82967f) to head (d3871a9).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1304   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gauravudia Gauravudia merged commit d02302c into develop Apr 5, 2024
16 of 17 checks passed
@Gauravudia Gauravudia deleted the feat/mixpanel-apiSecret-deprecate branch April 5, 2024 05:42
Gauravudia added a commit that referenced this pull request Apr 17, 2024
@Gauravudia Gauravudia restored the feat/mixpanel-apiSecret-deprecate branch May 15, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants