Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom screen call amplitude #1069

Merged
merged 3 commits into from
Nov 13, 2023
Merged

feat: custom screen call amplitude #1069

merged 3 commits into from
Nov 13, 2023

Conversation

aashishmalik
Copy link
Contributor

Description of the change

< custom screen call amplitude >

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • I have executed schemaGenerator tests and updated schema if needed

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b10504) 100.00% compared to head (39bfa85) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1069   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashishmalik
Copy link
Contributor Author

Screenshot 2023-11-13 at 2 35 22 AM

sanpj2292
sanpj2292 previously approved these changes Nov 13, 2023
@aashishmalik aashishmalik merged commit c78780e into develop Nov 13, 2023
5 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the feat.amp-screen branch February 14, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants