Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add generic consent management fields in initially onboarded destinations config #1058

Conversation

bardisg
Copy link
Contributor

@bardisg bardisg commented Nov 7, 2023

Description of the change

Added fields for generic consent management feature, under a feature flag prerequisite, for the initialy onboarded destinations of phase I

A new section has been added, with id consentSettings, that will display inside it any fields and all fields as source dependent fields from consentSettingsTemplate part of the ui-config

Webapp UI Screenshots

v2 Form Builder read only
Screenshot 2024-01-17 at 13 41 26

v2 Form Builder edit mode
Screenshot 2024-01-17 at 13 42 02

Legacy form builder read only
Screenshot 2023-11-13 at 14 23 51

Legacy Form Builder edit mode
Screenshot 2023-11-13 at 14 24 07

Loom videos

Database stored value evidence can be seen at https://linear.app/rudderstack/issue/SDK-660/update-consent-settings-in-destination-definitions-and-ui-config#comment-e40eea52

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

linear bot commented Nov 7, 2023

SDK-660 Update consent settings in destination definitions and UI config

Description

We need to update the following sample destinations in phase 1:

  • customer.io
  • mixpanel
  • snowflake

Research Spec

TBD

Scope

  • Update destination definitions for sample destinations
  • Update UI config for the sample destinations
  • Update validation schema configuration files for the above changes
  • add feature flag prerequisite in new fields
  • add and activate enable-gcm feature flag in amplitude dev
  • merge in dev post release od ketch cloud mode
  • add and activate enable-gcm feature flag in amplitude staging
  • add and activate enable-gcm feature flag in amplitude prod

POC
https://github.com/rudderlabs/rudder-integrations-config/pull/940/files

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f047bc3) 100.00% compared to head (140ef01) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1058   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           53        53           
  Branches         7         7           
=========================================
  Hits            53        53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bardisg bardisg marked this pull request as ready for review November 13, 2023 14:15
@bardisg bardisg changed the title Feature/sdk 660 update consent settings in destination definitions and UI feat: add generic consent management fields in initially onboarded destinations config Nov 13, 2023
@bardisg bardisg added the DO NOT MERGE Approved but need to check more label Nov 13, 2023
bardisg and others added 3 commits January 11, 2024 10:08
…n-destination-definitions-and-ui

# Conflicts:
#	src/configurations/destinations/customerio/ui-config.json
#	src/configurations/destinations/ga4/db-config.json
#	src/configurations/destinations/snowflake/schema.json
#	test/validation.test.ts
@bardisg
Copy link
Contributor Author

bardisg commented Jan 17, 2024

Designs have been updated in Figma, thus configuration is updated to match the new designs please review again

Figma designs: https://www.figma.com/file/6UWAV8VDNHxBnaW7RMd26X/branch/oVA1LUiRCbstj2Vaa48Mnl/%F0%9F%8F%9D%EF%B8%8F-Destinations?node-id=840%3A19200&mode=dev

@bardisg bardisg requested a review from krishna2020 January 17, 2024 11:38
bardisg and others added 5 commits January 19, 2024 09:50
…definitions-and-ui' of github.com:rudderlabs/rudder-integrations-config into feature/sdk-660-update-consent-settings-in-destination-definitions-and-ui
@bardisg
Copy link
Contributor Author

bardisg commented Jan 19, 2024

updated schemaGenerator to also cater for new consentSettingsTemplate section

@bardisg bardisg requested a review from saikumarrs January 19, 2024 09:56
saikumarrs
saikumarrs previously approved these changes Jan 19, 2024
…n-destination-definitions-and-ui

# Conflicts:
#	src/configurations/destinations/customerio/db-config.json
#	src/configurations/destinations/customerio/ui-config.json
@bardisg bardisg requested a review from saikumarrs January 26, 2024 10:50
@bardisg
Copy link
Contributor Author

bardisg commented Jan 26, 2024

Added OneTrust as default provider selection and no resolutionStrategy as default exists now

@bardisg bardisg requested a review from krishna2020 January 31, 2024 13:33
@bardisg bardisg merged commit 6f80bc9 into develop Feb 1, 2024
5 checks passed
@bardisg bardisg deleted the feature/sdk-660-update-consent-settings-in-destination-definitions-and-ui branch February 1, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants