Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update google ads image (ETL-189) #1048

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

nidhilashkari17
Copy link
Contributor

Description of the change

chore: update google ads image

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

linear bot commented Nov 2, 2023

ETL-189 Support for Incremental Syncs for google ads custom queries

!subteam^S03SW8KDFHPextract-on-call> for visibility


Notion document: https://www.notion.so/subteam-S03SW8KDFHP-extract-on-call-for-visibility-172eb9338ad74eb68f9d574fe0d792f8
Slack Link: https://rudderlabs.slack.com/archives/C017H2XKZ9R/p1697713733389889?thread_ts=1697713733.389889&cid=C017H2XKZ9R
Channel: ask-extract
Created By: Nidhi Lashkari
thread_id=<1697713733.389889>
channel_id=

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6344ce) 100.00% compared to head (833dff2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1048   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nidhilashkari17 nidhilashkari17 merged commit 6bbd11f into develop Nov 7, 2023
5 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the chore.google-ads-image-update branch February 3, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants