Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate GA and Facebook Offline Conversions destinations using options flag #1016

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

sandeepdsvs
Copy link
Contributor

@sandeepdsvs sandeepdsvs commented Oct 27, 2023

Description of the change

Resolves INT-807
Now deprecating destinations from creating new ones using deprecated flag in options.
GA and Facebook Offline Conversions are now deprecated using deprecated flag in options.

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@linear
Copy link

linear bot commented Oct 27, 2023

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e8e3d1) 100.00% compared to head (0e71723) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop     #1016   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           78        78           
  Branches        13        13           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeepdsvs sandeepdsvs merged commit b3a1567 into develop Oct 30, 2023
5 checks passed
@devops-github-rudderstack devops-github-rudderstack deleted the deprecate_ga_fboc branch January 31, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants