Skip to content

Commit

Permalink
feat: add Iubenda support to ga4 destination (#1691)
Browse files Browse the repository at this point in the history
Co-authored-by: Sai Kumar Battinoju <[email protected]>
  • Loading branch information
mohamedkhattab and saikumarrs authored Oct 9, 2024
1 parent 946b54d commit 2ef7ae4
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 11 deletions.
22 changes: 11 additions & 11 deletions src/configurations/destinations/ga4/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -388,7 +388,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -434,7 +434,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -480,7 +480,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -526,7 +526,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -572,7 +572,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -618,7 +618,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -664,7 +664,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -710,7 +710,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -756,7 +756,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down Expand Up @@ -802,7 +802,7 @@
"properties": {
"provider": {
"type": "string",
"enum": ["custom", "ketch", "oneTrust"],
"enum": ["custom", "iubenda", "ketch", "oneTrust"],
"default": "oneTrust"
},
"consents": {
Expand Down
4 changes: 4 additions & 0 deletions src/configurations/destinations/ga4/ui-config.json
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,10 @@
"label": "Custom",
"value": "custom"
},
{
"label": "Iubenda",
"value": "iubenda"
},
{
"label": "Ketch",
"value": "ketch"
Expand Down
11 changes: 11 additions & 0 deletions test/data/validation/destinations/ga4.json
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,17 @@
{
"provider": "ketch",
"consents": []
},
{
"provider": "iubenda",
"consents": [
{
"consent": "1"
},
{
"consent": "4"
}
]
}
]
}
Expand Down

0 comments on commit 2ef7ae4

Please sign in to comment.