Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test stubs for stocks API #172

Merged
merged 5 commits into from
Jun 1, 2024
Merged

Add test stubs for stocks API #172

merged 5 commits into from
Jun 1, 2024

Conversation

abachman
Copy link
Member

@abachman abachman commented Jun 1, 2024

This PR introduces WebMock and adds three tests for the StockPricesUpdateJob:

  1. Is the API called?
  2. Are records created? (skipped)
  3. Are records populated? (skipped)

@abachman abachman requested a review from LizPrescott June 1, 2024 20:07
@abachman abachman merged commit c77adf7 into main Jun 1, 2024
1 check passed
@abachman abachman deleted the stocks-api-test branch June 1, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LizPrescott LizPrescott LizPrescott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abachman @LizPrescott