Job now prints full output for all api calls. Next step, extract just… #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LizPrescott
force-pushed
the
update_stock_price
branch
from
295024e
to
4148dd4
Compare
… the ticket symbol and closing price
LizPrescott
force-pushed
the
update_stock_price
branch
from
4148dd4
to
5848fa1
Compare
h-m-m
reviewed
Jun 1, 2024
Comment on lines
+7
to
+11
| stock_symbols = ["KO", "SNE", "TWX", "DIS", "SIRI", "F", "EA", "FB", "UA", "LUV", "GPS"] | ||
| stock_symbols.each do |symbol| | ||
| api_request(symbol) | ||
| stock_db = Stock.find_by(ticker: symbol) | ||
| end |
There was a problem hiding this comment.
Maybe ensure the stock can be found in the DB before we request the stock? As written, would this cause the job to abort if the stock with one of the tickers can't be found, skipping the processing of any further stocks in the list
There was a problem hiding this comment.
.find_by is okay here, since it returns nil instead of raising NotFoundError
There was a problem hiding this comment.
Oh, I forgot about that, thanks.
This means we'll have to do nil checks, though
abachman
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the ticket symbol and closing price