Pull in earlier config files #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-m-m
force-pushed
the
config-salvaged
branch
4 times, most recently
from
72ba8fe
to
e2aab2e
Compare
maks112v
reviewed
May 23, 2024
| @@ -1 +1 @@ | |||
| ruby-3.2.3 | |||
| ruby-3.2.2 | |||
There was a problem hiding this comment.
Why is the ruby version being downgraded, are there issues with the higher version?
There was a problem hiding this comment.
I put it in the commit message, and I'll copy it here, too.
It looks like ubuntu-latest in GH actions is the latest patch of LTS
22, not LTS 24. I probably could add something to get updated packages
so 3.2.3 is available. I want to first check if the project has any
other problems before getting into the weeds
There was a problem hiding this comment.
This is part of the reason I have this PR still marked as draft
maks112v
approved these changes
May 23, 2024
This pulls a few select config files files from commit 40313a8 which should be the last commit before a new Rails app was initialized
It looks like `ubuntu-latest` in GH actions is the latest patch of LTS 22, not LTS 24. I probably could add something to get updated packages so 3.2.3 is available. I want to first check if the project has any other problems before getting into the weeds
|
Per @abachman's suggestion, closing this PR to split it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pulls a few select config files files prior to #116
Details
I'm opening this initially as a draft to see what, if any, of the github workflow features will work with out much effort.
I also think we should spend at least a minute or two considering if any of these are no longer appropriate