Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_https.rb - fix test_session_reuse_but_expire #178

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

MSP-Greg
Copy link
Contributor

See issue ruby/openssl#703

Currently, test code uses http.ssl_timeout = -1. A negative timeout many would consider to be undefined. As discussed in the ruby/openssl issue, OpenSSL 3.2 changed the timeout value type from signed to unsigned.

So, the previous test was relying on behavior that was undefined.

Changed the timeout value to 1, and added a sleep 1.25 command to wait for the second socket connection.

Using a negative value previously performed the equivalent of 'no session reuse'. A better solution would be to add
a session_cache_mode accessor. I can do that in another PR if there's interest.

@hsbt
Copy link
Member

hsbt commented Jul 11, 2024

I try this with ruby/ruby.

@hsbt hsbt merged commit 42f7187 into ruby:master Jul 11, 2024
15 checks passed
@MSP-Greg MSP-Greg deleted the 00-session-expire branch July 11, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants