test_https.rb - fix test_session_reuse_but_expire #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue ruby/openssl#703
Currently, test code uses
http.ssl_timeout = -1
. A negative timeout many would consider to be undefined. As discussed in the ruby/openssl issue, OpenSSL 3.2 changed the timeout value type from signed to unsigned.So, the previous test was relying on behavior that was undefined.
Changed the timeout value to
1
, and added asleep 1.25
command to wait for the second socket connection.Using a negative value previously performed the equivalent of 'no session reuse'. A better solution would be to add
a
session_cache_mode
accessor. I can do that in another PR if there's interest.