Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1124] Fix false positives for Rails/RedundantActiveRecordAllMethod #1127

Conversation

koic
Copy link
Member

@koic koic commented Sep 19, 2023

Fixes #1124.

This PR fixes false positives for Rails/RedundantActiveRecordAllMethod when receiver is not an Active Record model.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…rdAllMethod`

Fixes rubocop#1124.

This PR fixes false positives for `Rails/RedundantActiveRecordAllMethod`
when receiver is not an Active Record model.
@jorg-vr
Copy link

jorg-vr commented Sep 19, 2023

If I understand this correctly, this pr adds specific allowed receivers.

This would not solve the issue for this case: dodona-edu/dodona#4987
Where we use Docker::Container.all from https://github.com/upserve/docker-api

I think we need a more general solution

@koic
Copy link
Member Author

koic commented Sep 20, 2023

I have written an explanation here: #1124 (comment)

@koic koic merged commit 0a57811 into rubocop:master Sep 25, 2023
4 checks passed
@koic koic deleted the fix_false_positive_for_rails_redundant_active_record_dll_method branch September 25, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive when the receiver of all is not an ActiveRecord object
2 participants