Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update jshint exception switch to current jshint version #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clue42
Copy link

@clue42 clue42 commented Feb 20, 2015

update the jshint exception switch to current (2.6.0) version for
mixed quotation marks. As of jshint > 1.0 this exception is W110 instead
of the used W100

update the jshint exception switch to current (2.6.0) version for
mixed quotation marks. As of jshint > 1.0 this exception is W110 instead
of the used W100
@clue42 clue42 closed this Feb 20, 2015
@clue42 clue42 reopened this Feb 20, 2015
@rubenv
Copy link
Owner

rubenv commented Feb 20, 2015

How was this working before?

@clue42
Copy link
Author

clue42 commented Feb 20, 2015

Jshint was throwing warnings and if you do have quite a few translations, linting your source got pretty annoying.

@clue42 clue42 closed this Feb 20, 2015
@clue42 clue42 reopened this Feb 20, 2015
@rubenv
Copy link
Owner

rubenv commented Feb 20, 2015

Ah yes. Well, I stand by my point that you should ignore generated files from linting.

This might happen again and it's totally pointless. Just don't lint machine-generated stuff, it's a waste of time.

@clue42
Copy link
Author

clue42 commented Feb 20, 2015

Well, I stumbled across this as where were some exception switches in the code, however just old ones.

@gabegorelick
Copy link
Collaborator

If we already add a JSHint directive to the generated JS, I suppose we should at least use the right directive :-)

But honestly, I would vote for not outputting any JSHint directives. Or maybe jshint:ignore

@tylkomat
Copy link

completely disabling jshint on the compiled file is the right choice, as one does not have influence on the global jshint settings of the developer and also one can't influence the generated code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants