Added translate="no" logic

[rleshchenko]

What?

Logic to exclude translate="no" tags from extract command scope

Why?

So far google chrome supports translate="no" attribute for the content which is not going to be translated by automatic google translate plugin or any other translation. In this PR you can find a logic to do such a thing. Proof:
https://cloud.google.com/translate/faq#technical_questions

Testing / Proof

Run gulp gettext:extract on the template with the translate="no" attribute

ping @rubenv

[rubenv]

Excluding strings from extraction won't stop them from being handled by the runtime code. I recommend that you use the class="notranslate" method when using angular-gettext.

I'm hesitant to include this as it might break existing code. Please also include a unit test with pull requests.

[rleshchenko]

Excluding strings from extraction won't stop them from being handled by the runtime code. I recommend that you use the class="notranslate" method when using angular-gettext.

I'm hesitant to include this as it might break existing code. Please also include a unit test with pull requests.

But still, this attribute is very common. The current implementation makes impossible correct behaviour of applications already marked with such a tag. I will create tests and fix for runtime code and ping you then

[rubenv]

The current implementation makes impossible correct behaviour of applications already marked with such a tag.

Yes you can: replace every translate="no" with class="notranslate".

[rleshchenko]

The current implementation makes impossible correct behaviour of applications already marked with such a tag.

Yes you can: replace every translate="no" with class="notranslate".

But notranslate won't be recognized with plugins for a browser or automated translation from google. But translate="no" does. That's a thing

[rubenv]

It's right there in the link you gave (https://cloud.google.com/translate/faq#technical_questions):

How do I tell Cloud Translation API to NOT translate something?

You can use the following HTML tags:

    <span translate="no"> </span>
    <span class="notranslate"> </span>

This functionality requires the source text to be submitted in HTML.

[rleshchenko]

It's right there in the link you gave (https://cloud.google.com/translate/faq#technical_questions):

How do I tell Cloud Translation API to NOT translate something?

You can use the following HTML tags:

    <span translate="no"> </span>
    <span class="notranslate"> </span>

This functionality requires the source text to be submitted in HTML.

Oh, sorry, my bad, didn't see that notranslate there. So there is no way to support both attribute and class?

[rubenv]

Well, I'd rather not introduce any (potentially breaking) changes if there's an alternative solution. As per rubenv/angular-gettext#365, this project is in maintenance mode.

Whatever changes land now cannot break any existing applications, even if the risk is small.

[rleshchenko]

@rubenv, thank you then. Will close PR and proceed with current implementation

[rubenv]

Will close PR and proceed with current implementation

Good luck! Feel free to follow-up if things don't work out.