Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages order info #2104

Merged
merged 14 commits into from
Nov 7, 2024
Merged

Pages order info #2104

merged 14 commits into from
Nov 7, 2024

Conversation

erikaas24
Copy link
Contributor

Changes

What has been done

  • I have added parameters to the query and backend so that we can ask for specific parts of the Orders-data
  • Updated front-end to support pagination
  • Adjusted some CSS on the front-end

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
indok-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 4:15pm

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.29%. Comparing base (e6f2a93) to head (503ba00).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
backend/apps/ecommerce/resolvers.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2104   +/-   ##
=======================================
  Coverage   83.28%   83.29%           
=======================================
  Files         100      100           
  Lines        3572     3580    +8     
=======================================
+ Hits         2975     2982    +7     
- Misses        597      598    +1     
Flag Coverage Δ
apitests 83.29% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MagnusHafstad MagnusHafstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename the allShopOrders query

…300 orders per query, changed the name of the query
Copy link

cypress bot commented Oct 21, 2024

Indøk Web    Run #3342

Run Properties:  status check passed Passed #3342  •  git commit 00f7867797 ℹ️: Merge 503ba0071cf1b8fedc3a990f2532cf2beea67c03 into a0974e286987be112a87fbabf978...
Project Indøk Web
Branch Review Pages-order-info
Run status status check passed Passed #3342
Run duration 01m 36s
Commit git commit 00f7867797 ℹ️: Merge 503ba0071cf1b8fedc3a990f2532cf2beea67c03 into a0974e286987be112a87fbabf978...
Committer Erik Aas
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

Copy link
Contributor

@MagnusHafstad MagnusHafstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extremely good work on this. It should be tested, but i understand if you want to merge as is and it is okey. That being said automated testing is one of the most important things we do to keep the site running so someone will have to add it at some point in the very near future.

@MagnusHafstad
Copy link
Contributor

The E2E tests are a bit flaky. If it fails try to run it again bu pressing details then rerun jobs. It I higly doubt the fail on E2E1 is acutally your doing. That said if rerunning does not fix it you shouldn't merge.

Copy link

sonarcloud bot commented Nov 7, 2024

@erikaas24 erikaas24 merged commit a48df64 into main Nov 7, 2024
20 of 21 checks passed
@erikaas24 erikaas24 deleted the Pages-order-info branch November 7, 2024 17:15
Copy link

cypress bot commented Nov 7, 2024

Indøk Web    Run #3343

Run Properties:  status check passed Passed #3343  •  git commit a48df64d7f: Pages order info (#2104)
Project Indøk Web
Branch Review main
Run status status check passed Passed #3343
Run duration 01m 42s
Commit git commit a48df64d7f: Pages order info (#2104)
Committer Erik Aas
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants