-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pages order info #2104
Pages order info #2104
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2104 +/- ##
=======================================
Coverage 83.28% 83.29%
=======================================
Files 100 100
Lines 3572 3580 +8
=======================================
+ Hits 2975 2982 +7
- Misses 597 598 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rename the allShopOrders query
…300 orders per query, changed the name of the query
Indøk Web Run #3342
Run Properties:
|
Project |
Indøk Web
|
Branch Review |
Pages-order-info
|
Run status |
Passed #3342
|
Run duration | 01m 36s |
Commit |
00f7867797 ℹ️: Merge 503ba0071cf1b8fedc3a990f2532cf2beea67c03 into a0974e286987be112a87fbabf978...
|
Committer | Erik Aas |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
2
|
View all changes introduced in this branch ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extremely good work on this. It should be tested, but i understand if you want to merge as is and it is okey. That being said automated testing is one of the most important things we do to keep the site running so someone will have to add it at some point in the very near future.
The E2E tests are a bit flaky. If it fails try to run it again bu pressing details then rerun jobs. It I higly doubt the fail on E2E1 is acutally your doing. That said if rerunning does not fix it you shouldn't merge. |
Quality Gate passedIssues Measures |
Indøk Web Run #3343
Run Properties:
|
Project |
Indøk Web
|
Branch Review |
main
|
Run status |
Passed #3343
|
Run duration | 01m 42s |
Commit |
a48df64d7f: Pages order info (#2104)
|
Committer | Erik Aas |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
2
|
View all changes introduced in this branch ↗︎ |
Changes
What has been done