Fix CMakes

[aljen]

Prefix options with RTTR_ and if it's added as a subdirectory, turn everything off (examples, docs, etc.)

[acki-m]

For what is this if and the code below?

[aljen]

This if will get fired only if you open this project CMakeLists.txt as a top, standalone project, but it will not if it's parsed for example from add_subdirectory(vendor/rttr)

[acki-m]

I think you should go with 4 spaces here for indention

[acki-m]

RTTR_ and if it's added as a subdirectory, turn everything off (examples, docs, etc.)
What is the reason for this?
So why prefix? And Why disable the other stuff?

[aljen]

What is the reason for this?
So why prefix? And Why disable the other stuff?

Mainly - if you're building this project alone, as a standalone library - it's working as it was, but if you're just a client and do something like add_subdirectory it from another project like most of the third party integrations are done (mainly on Windows, on *nix there are tons of package managers, from which I can install this library), it will disable all tests, benchmarks, docs, etc.

And why prefix it?

Here is a snippet from root CMakeLists.txt of my homebrew engine:

# set(BUILD_PACKAGE OFF)
# set(BUILD_UNIT_TESTS OFF)
# set(BUILD_STATIC ON)
# set(BUILD_EXAMPLES OFF)
# set(BUILD_DOCUMENTATION OFF)
# set(BUILD_INSTALLER OFF)
# set(BUILD_PACKAGE OFF)
# set(USE_PCH OFF)
# add_subdirectory(vendor/rttr)

add_subdirectory(vendor/glad)
add_subdirectory(vendor/sdl2)

Right now, it will fail to parse my project, because docs are default to ON, examples too, and me as a user of your library don't care for tests, packaging, examples, documentation, installer, etc.

But I need to set those variables before I add_subdirectory your library and those variables will leak to every add_subdirectory on the way, what if some other library used for example USE_PCH or my own (they're not :P)? 😃

So prefixing them with RTTR_ will partially solve this problem, but the real solution is to not enable them in the first place if you detect you're being built as a subproject 😃

[acki-m]

Okay I got it, that the variable names will leak to other libraries. So this change is okay. However, I don't like this implicit behavior. When you do it in this context then the variables defaults will changes.
And then someone else is coming and still want to have the docs generated, etc...

Please just set the variables default how you like it before calling add_subdirectory(vendor/rttr) and that's it.