Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tick api to osal #19

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Add tick api to osal #19

merged 1 commit into from
Feb 27, 2023

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Feb 14, 2023

Tests

  • Tested on linux
  • Tested on windows
  • Tested on rt-kernel
  • Tested on freertos

Todo

  • Mark old time function as deprecated?
  • Add api to get tick frequency?

Related to #18

@elupus
Copy link
Contributor Author

elupus commented Feb 14, 2023

Should we add a tick frequency API? I would prefer to not add a tick_to_time api since that would easily suffer same overflow issues that the old time based api tends to suffer.

@elupus elupus force-pushed the tickapi branch 2 times, most recently from d46697d to b275cc2 Compare February 14, 2023 15:36
@elupus elupus marked this pull request as ready for review February 27, 2023 14:03
Copy link
Contributor

@hefloryd hefloryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but doesn't build on Windows yet.

test/test_osal.cpp Outdated Show resolved Hide resolved
test/test_osal.cpp Outdated Show resolved Hide resolved
@hefloryd hefloryd merged commit 6810d3d into rtlabs-com:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants