Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: allow running multiple kanata instances concurrently #13

Merged
merged 14 commits into from
Mar 21, 2024

Conversation

rszyma
Copy link
Owner

@rszyma rszyma commented Mar 6, 2024

Closes #10

TODO:

  • update README.md

@rszyma rszyma marked this pull request as ready for review March 9, 2024 13:38
@rszyma
Copy link
Owner Author

rszyma commented Mar 13, 2024

I noticed that the presets in tray menu are being displayed in random order after being read from config file. It's happening because we parse presets into golang's map, which doesn't support preservation of order of insertions.

To fix this a wrapper for map like this one would need to be used, however the toml parsing library we currently use have no support for parsing complex types into custom structs.

Edit: pelletier/go-toml has a unstable api workaround to get order of mappings

@rszyma
Copy link
Owner Author

rszyma commented Mar 20, 2024

  • Only general.allow_concurrent_presets is left to be implemented now I think?

Also:

  • disable "Open Logs" button when no previous log is available

@rszyma rszyma merged commit 48ae2a6 into main Mar 21, 2024
2 checks passed
@rszyma rszyma changed the title feat: allow running multiple kanata instances concurrently feat!: allow running multiple kanata instances concurrently Mar 21, 2024
@rszyma rszyma deleted the multiple-simltaneous-instances branch March 21, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Multiple Kanata instances with unique configurations
1 participant