fix: Fix checking if scope is a jquery element
#4176
+32
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadenbuie
force-pushed
the
fix/binding-check-jquery
branch
from
ec327ab to
db123a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rstudio/bslib#1159
Apparently there are cases where
.bindAll()can be called on a text node rather than an HTMLElement or a jquery-wrapped element. The code path where this was observed was through theshiny-insert-tabmessage handler (see linked issue for a reprex).I couldn't track down how that behavior arises. But it only becomes relevant for us when we want to dispatch the error console event since you can't dispatch an event on a text node.
This PR improves the check that differentiates between jQuery objects and DOM nodes and ensures that
checkValidity()doesn't try to dispatch an event or call.get()on a text node.