feat: Run examples from any package #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
Mar 21, 2024
schloerke
reviewed
Mar 21, 2024
schloerke
reviewed
Mar 21, 2024
schloerke
approved these changes
Mar 21, 2024
cpsievert
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible for any package to provide shiny examples in
inst/examples-shinyand have them be runnable/discoverable viarunExample().This PR simply exposes
packagein therunExample()function signature, giving us the core feature described in #3907. The work in #3917 is still useful to make this feature more user-friendly and can be done in the next release. But we can get the core feature out in the wild so people can start to use it.Note that for non-shiny packages, the examples directory must be
inst/examples-shiny. Theshiny.legacy.examplesoption only has takes effect when looking for examples in shiny itself.Note: stacks on top of #4003. We can merge this into #4003 so we can merge the examples changes all at once.