-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give user an option to run shiny-server as root #391
base: master
Are you sure you want to change the base?
Conversation
@jcheng5 will appreciate it if you can provide any feedback/comments! |
I can't in good conscience accept this--the risks are so huge. Is there a reason you can't run as a different user? |
Thank you @jcheng5 for your feedback! I'm running shiny-server inside a Docker container, which isolates all environment inside the container: both file system and processes:https://github.com/QPod/docker-images I chose to use the root user inside docker for simplicity reasons, where a user can do everything inside the container, and risks are isolated/controlled by docker. I understand there is un-ignorable risk to run shiny-server as the root user.
|
- Buffer constructor is deprecated, use .from and .alloc instead - Fix v8.h related compiler warnings
Upgrade Node.js to v10.15.3
Exclude testing-related npm packages from installer
…re-test Install all dependencies before running tests
The script does a lot of work to set up the right environment
Was running npm from the wrong directory
We're still a couple of week away from dropping Ubuntu 14.04 so holding off on that one. https://www.rstudio.com/about/platform-support/
Currently, if the user runs the process of
shiny-server
in root and defines run_as to root, the shiny-server will abort.It is possible (and secure) to allow users to run the process in root and run_as root?