Add libssh rule #159
Merged
Add libssh rule #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glin
reviewed
Mar 21, 2024
Co-authored-by: Greg Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a rule for libssh
Noticed an issue when trying to run a build which requires the R package https://github.com/ropensci/ssh
Example error here https://github.com/mrc-ide/hintr/actions/runs/8172298442/job/22342313071#step:5:7594
This is because ssh package requires libssh, not libssh2 as mentioned in the DESCRIPTION. This is pulling in libssh2 because DESCRIPTION text mentions libssh2.
After this PR should see in the tests
plumberDeployandsshmatching this new rule.They are both still matched by libssh2 rule, but that's probably something that should be fixed in the package DESCRIPTION