-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #201 from rstudio/libgit2
Install newer libgit2 on RHEL 8 for git2r
- Loading branch information
Showing
1 changed file
with
11 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
665bc93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glin
This change results in a conflict with crb:
Is this change really needed? This will conflict on any OS which has
libgit2-devel
installed. Besides,libgit2_1.7-devel
is a version specific name, possibly requiring additional maintenance in the future.Yes,
libgit2
from CRB is old but AFAICS still functional?665bc93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git2r does not install with the CRB version:
#201 (comment)
https://forum.posit.co/t/not-able-to-install-git2r/196545/7
665bc93
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry, I don't think there was any package that could use that old libgit2 from CRB anyway though. Other than git2r, gert also depends on libgit2 >= 1.0.
For conflicts in general, installing the non-devel packages shouldn't conflict, so you could install
libgit2_1.7
from EPEL to keep both libgit2 versions. For a more automatic solution, we're likely going to get #151 in soon, so there'd be a possibility to get only the non-devel packages which would have less conflicts.