Improve as_gtable()
width calculations
#1931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fix #1923.
I've tried to mirror to CSS specifications more closely with the constraint that grid can't automatically reflow text.
See examples below.
Related GitHub Issues and PRs
Checklist
testthat
unit tests totests/testthat
for any new functionality.Examples
Based on the reprex in the linked issue, showing the plot with no total width contraints, a relative width and an absolute width contraint.
Created on 2024-12-09 with reprex v2.1.1