Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity of the new parser #402

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Conversation

V0ldek
Copy link
Member

@V0ldek V0ldek commented Jan 2, 2024

Short description

New parser replacing all old parsing logic.

This is not release-ready, there is a few cleanup tasks left:

  • update fuzz and prop tests
  • consolidate parsing tests to occur only in the syntax crate and not in lib
  • verify documentation

Unfortunately, this breaks some queries (those asking to match control characters). Look to #117 for tracking.

Issue

Resolves: #129
Part of: #116

Checklist

All of these should be ticked off before you submit the PR.

  • I ran just verify locally and it succeeded.
  • Issue was given go ahead and is linked above OR I have included justification for a minor change.
  • Unit tests for my changes are included OR no functionality was changed.

@V0ldek V0ldek force-pushed the v0ldek/separate-parser-crate branch from 31c274b to 739b89e Compare January 2, 2024 12:27
@V0ldek V0ldek force-pushed the v0ldek/separate-parser-crate branch from 7644b9d to ff3749f Compare January 2, 2024 14:48
@V0ldek V0ldek merged commit 7a64917 into main Jan 2, 2024
45 checks passed
@V0ldek V0ldek deleted the v0ldek/separate-parser-crate branch January 2, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better parser error messages
1 participant