Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

US-2119: Adding Trace ID #899

Merged
merged 2 commits into from
Mar 7, 2024
Merged

US-2119: Adding Trace ID #899

merged 2 commits into from
Mar 7, 2024

Conversation

sleyter93
Copy link
Collaborator

@sleyter93 sleyter93 commented Feb 29, 2024 •
edited
Loading

https://rsklabs.atlassian.net/browse/US-2119

  1. Validate at the beginning if TRACE_ID is set up.
  2. Sent TRACE_ID to WebSocket through headers.

If you did not set TRACE_ID, the app will show the following screen:
Screenshot 2024-03-03 at 23 05 11

@sleyter93 sleyter93 self-assigned this Feb 29, 2024
TravellerOnTheRun
TravellerOnTheRun requested changes Feb 29, 2024
View reviewed changes
src/core/Core.tsx Outdated Show resolved Hide resolved
@sleyter93 sleyter93 force-pushed the feature/tracing branch 2 times, most recently from 34351e6 to 60d4820 Compare March 1, 2024 05:07
TravellerOnTheRun
TravellerOnTheRun requested changes Mar 1, 2024
View reviewed changes
src/core/Core.tsx Outdated Show resolved Hide resolved
src/redux/slices/settingsSlice/index.ts Show resolved Hide resolved
src/redux/slices/settingsSlice/types.ts Outdated Show resolved Hide resolved
jessgusclark
jessgusclark requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach, we need to also add something to the readme file explaining they need to add a value.

.env Outdated Show resolved Hide resolved
src/core/Core.tsx Outdated Show resolved Hide resolved
@sleyter93 sleyter93 force-pushed the feature/tracing branch 2 times, most recently from 2e020b6 to 3c28f4f Compare March 4, 2024 04:01
TravellerOnTheRun
TravellerOnTheRun requested changes Mar 4, 2024
View reviewed changes
src/redux/slices/settingsSlice/index.ts Outdated Show resolved Hide resolved
src/redux/slices/settingsSlice/index.ts Outdated Show resolved Hide resolved
src/redux/slices/settingsSlice/types.ts Outdated Show resolved Hide resolved
TravellerOnTheRun
TravellerOnTheRun approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@TravellerOnTheRun TravellerOnTheRun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for changing the GlobalError to use translation! Let's merge that in

@jessgusclark jessgusclark merged commit f7139fe into develop Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravellerOnTheRun TravellerOnTheRun TravellerOnTheRun approved these changes

@jessgusclark jessgusclark jessgusclark approved these changes

Assignees

@sleyter93 sleyter93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sleyter93 @jessgusclark @TravellerOnTheRun