Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance deployment transaction #772

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Enhance deployment transaction #772

merged 1 commit into from
Oct 18, 2023

Conversation

sleyter93
Copy link
Collaborator

@sleyter93 sleyter93 commented Oct 11, 2023 •
edited
Loading

We enhance deployment transaction, and the label in activity row should show 'Rif Wallet Deployment'.
Screenshot 2023-10-11 at 16 17 59

@sleyter93 sleyter93 self-assigned this Oct 11, 2023
@sleyter93 sleyter93 requested a review from jormelCoin October 11, 2023 21:16
jormelCoin
jormelCoin approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@jormelCoin jormelCoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked as expected

Screenshot 2023-10-12 at 11 58 44

@jormelCoin jormelCoin added Tested Ready to move forward and removed Ready for Testing labels Oct 12, 2023
Freshenext
Freshenext approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@Freshenext Freshenext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code ok.
Functionality there is only one thing - for some reason for old transactions it's not working - but if I create a new wallet then it works - anyways this is OK.

@Freshenext Freshenext merged commit a6630b6 into develop Oct 18, 2023
1 check passed
@Freshenext Freshenext deleted the feature/deploy-tx branch October 18, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jormelCoin jormelCoin jormelCoin approved these changes

@Freshenext Freshenext Freshenext approved these changes

@jessgusclark jessgusclark Awaiting requested review from jessgusclark

Assignees

@sleyter93 sleyter93

Labels
Tested Ready to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sleyter93 @Freshenext @jormelCoin @jessgusclark