added tokens interface #7
Conversation
chescalante
force-pushed
the
feature/US-264-tokens
branch
from
01afd67 to
1a26e57
Compare
src/lib/token/ERC20Token.ts
Outdated
| public async balance(): Promise<BigNumber> { | ||
| const account = await this.account() | ||
|
|
||
| const decimals = await this.decimals() | ||
|
|
||
| const balance = await this.tokenContract.balanceOf(account) | ||
|
|
||
| return balance.div(tenPow(decimals)) | ||
| } | ||
|
|
||
| public async transfer( | ||
| recipientAddress: string, | ||
| amount: BigNumberish, | ||
| options?: ITransferOptions, | ||
| ): Promise<ContractTransaction> { | ||
| return this.tokenContract.transfer(recipientAddress, amount, { | ||
| ...options, |
There was a problem hiding this comment.
I have some concerns:
- This is not consistent int units. One returns the real value and the other uses the blockchain value
- Is this working with decimals? I guess not...
There was a problem hiding this comment.
I wasn't sure about that but I test it and it doesn't work, so I made a few changes to remove the div I believe we don't need that for now. Let me know what you think about it.
| TokenType, | ||
| } from './BaseToken' | ||
|
|
||
| class RBTCToken extends BaseToken implements IToken { |
There was a problem hiding this comment.
I are only working with testnet now. Let's add TRBTC too. I guess it is a different entity, maybe inherits all the same but overriding the symbol
There was a problem hiding this comment.
I made a few changes regarding this, let me know if it's ok for now.
Co-authored-by: Ilan <[email protected]>
Co-authored-by: Ilan <[email protected]>
| export type { ERC20 } from "./ERC20"; | ||
| export type { ERC677 } from "./ERC677"; | ||
|
|
||
| export { ERC20__factory } from "./factories/ERC20__factory"; | ||
| export { ERC677__factory } from "./factories/ERC677__factory"; |
There was a problem hiding this comment.
Are these auto-generated? Should we ignore them? And, why ERC677? We are using just ERC20 methods for now
There was a problem hiding this comment.
it was auto generated, but I made a copy from other project because I think this won't change, it makes sense to you? do you prefer to be auto generated with typechain?
No description provided.