Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RIF Wallet v2 core - Complete #26

Merged
merged 21 commits into from
Oct 22, 2021
Merged

Use RIF Wallet v2 core - Complete #26

merged 21 commits into from
Oct 22, 2021

Conversation

jessgusclark
Copy link
Member

@jessgusclark jessgusclark commented Oct 20, 2021

  • Uses new core from @rsksmart/rif-wallet branch v2.
    • The only changes to core so far was to fix lint issues and add getChainId method.
    • Does not pull over the tests.
  • Implements new KMS which is saved into storage. The Key has changed, so loading the app will now create a new account and save it with its new format.
  • Updates send and receive screens to use { account: RIFWallet } instead of { account: Account}
  • Updates a few tests, including smartWalletAddress which is no longer a promise.
  • Uses the ERC20 class to send RIF in tempscreens/smartwallet.ts screen

Pending:

  • Sending RIF does not work because of an error interacting with the contracts.
  • Receive screen is broken because there is an issue with getting the chainId. Will be fixed with this PR Replace library #6
  • Picker test is failing

future:

  • has only a single RIFWallet, this could be changed to loop through the saved accounts, or add accounts.
  • restoring and creating the KMS is handled in context. When the create wallet screens are complete, this logic can move to them and the context can expose a getter/setter for the KMS.

@jessgusclark jessgusclark changed the title Use RIF Wallet v2 core - In progress Use RIF Wallet v2 core - Complete Oct 21, 2021
@jessgusclark jessgusclark marked this pull request as ready for review October 21, 2021 11:04
@jessgusclark jessgusclark requested review from ilanolkies, lucachaco and chescalante and removed request for ilanolkies and lucachaco October 21, 2021 11:05
@ilanolkies
Copy link
Contributor

Ref: #5

@ilanolkies ilanolkies added the enhancement New feature or request label Oct 21, 2021
@ilanolkies ilanolkies added this to the v1.0.0 milestone Oct 21, 2021
@ilanolkies
Copy link
Contributor

Closes #20

Copy link
Contributor

@ilanolkies ilanolkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updated core. Made changes on onConfirm to get just { gasPrice, gasLimit }
  • Updated ReviewTransactionModal. It now edits only gasPrice and gasLimit

@ilanolkies ilanolkies merged commit 310ea9d into main Oct 22, 2021
@jessgusclark jessgusclark deleted the new-core branch November 29, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants