Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes with how the powpeg node interacts with the SVP protocol #353

Open
wants to merge 2 commits into
base: feat/powpeg_validation_protocol-phase4
Choose a base branch
from
Open

Some fixes with how the powpeg node interacts with the SVP protocol #353

wants to merge 2 commits into from
+20 −9

Conversation

apancorb
Copy link
Contributor

@apancorb apancorb commented Nov 21, 2024 •
edited
Loading

Description

Similar to previous PR. The call to get the svp spend tx wfs should also be behind the RSKIP419 check before Lovell is activated.

Motivation and Context

https://github.com/rsksmart/RSKIPs/blob/master/IPs/RSKIP419.md

How Has This Been Tested?

Locally in Regtest.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@apancorb apancorb self-assigned this Nov 21, 2024
@apancorb apancorb marked this pull request as ready for review November 21, 2024 11:19
@apancorb apancorb requested a review from a team as a code owner November 21, 2024 11:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

jeremy-then
jeremy-then approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.3% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarQube Cloud

@apancorb apancorb changed the title Place call to get svp spend tx wfs behind RSKIP419 Some fixes with how the powpeg node interacts with the SVP protocol Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanieliov nathanieliov nathanieliov approved these changes

@jeremy-then jeremy-then jeremy-then approved these changes

@julia-zack julia-zack julia-zack approved these changes

Assignees

@apancorb apancorb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apancorb @julia-zack @jeremy-then @nathanieliov