Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getLiveFederations method from FederationProvider #345

Merged

Conversation

apancorb
Copy link
Contributor

@apancorb apancorb commented Nov 7, 2024

Summary

Remove unused method getLiveFederations method from FederationProvider.

@apancorb apancorb self-assigned this Nov 7, 2024
@apancorb apancorb marked this pull request as ready for review November 7, 2024 10:15
@apancorb apancorb requested a review from a team as a code owner November 7, 2024 10:15
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we ever need these changes in the future? Anyways, LGTM.

@apancorb
Copy link
Contributor Author

apancorb commented Nov 7, 2024

Will we ever need these changes in the future? Anyways, LGTM.

Probably not

@marcos-iov marcos-iov merged commit 5b38bf2 into feat/powpeg_validation_protocol-phase4 Nov 7, 2024
7 checks passed
@marcos-iov marcos-iov deleted the feat/live_fed_remove branch November 7, 2024 20:46
apancorb pushed a commit that referenced this pull request Nov 19, 2024
Remove getLiveFederations method from FederationProvider
apancorb pushed a commit that referenced this pull request Dec 6, 2024
Remove getLiveFederations method from FederationProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants