Fixing some issues on RIT workflow #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmacleal
force-pushed
the
fmacleal/fix_rit_tests
branch
2 times, most recently
from
da891f5
to
f93d9da
Compare
Vovchyk
requested changes
Sep 16, 2024
fmacleal
force-pushed
the
fmacleal/fix_rit_tests
branch
4 times, most recently
from
74ddabd
to
7d59440
Compare
Issues fixed: 1 - Remove the trigger on push for master and *-rc -> we don't need that anymore since we are running it for every commit on PRs against these branches. 2 - Send the status of the execution to slack 3 - Solve the issue that the status of an execution triggered via workflow doesn't update the PR status. And if we need to use a different branch for RIT, Powpeg and RIT in the PR, it won't change the status to green after the workflow_dispatch execution -> We will do that adding a parsing on the description, looking for the branch that need to be used for that PR. If there is no branch configured on the description, we will try to use the default one. Branches to be used by RIT: fed:vovchyk/jackson-ver-bump rskj:vovchyk/jackson-ver-bump
fmacleal
force-pushed
the
fmacleal/fix_rit_tests
branch
from
7d59440
to
6edb048
Compare
lucasvuotto
suggested changes
Sep 20, 2024
Co-authored-by: Lucas <[email protected]>
fmacleal
force-pushed
the
fmacleal/fix_rit_tests
branch
from
ca0d73d
to
671d9e9
Compare
|
marcos-iov
approved these changes
Sep 24, 2024
Vovchyk
approved these changes
Sep 24, 2024
|
pipeline:run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues fixed:
1 - Remove the trigger on push for master and *-rc -> we don't need that anymore since we are running it for every commit on PRs against these branches. 2 - Send the status of the execution to slack
3 - Solve the issue that the status of an execution triggered via workflow doesn't update the PR status. And if we need to use a different branch for RIT, Powpeg and RIT in the PR, it won't change the status to green after the workflow_dispatch execution -> We will do that adding a parsing on the description, looking for the branch that need to be used for that PR. If there is no branch configured on the description, we will try to use the default one.
Branches to be used by RIT:
fed:vovchyk/jackson-ver-bumprskj:vovchyk/jackson-ver-bump