Powpeg-node Configuration Refactor #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcos-iov
force-pushed
the
powhsm-bookkeping-config-integration
branch
2 times, most recently
from
63a2edd to
9c99021
Compare
marcos-iov
force-pushed
the
powhsm-bookkeping-config-integration
branch
from
9c99021 to
461dd1d
Compare
marcos-iov
approved these changes
Aug 23, 2024
…nt with the codebase
refactor(config): rename local variable in PowHSM config test
…rget config is not present in config file
refactor(config): fix typos in powHSM config tests
refactor(config): add sonar comments to refactor of powpeg-node config refactor(config): resolve comments refactor(btcreleaseclient): fix sonar warning
refactor(config): resolve comments
feat(config): nit rebase changes feat(config): sonar comments
marcos-iov
force-pushed
the
powhsm-bookkeping-config-integration
branch
from
b5fc935 to
1b6f810
Compare
|
|
pipeline:run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change presents a major refactor to how configuration is handled in the
powpeg-node. What follows is a list of a few major changes:difficultyTargetconfig value from PowHSMblockchainParametersRPCPowHSMBookkeepingConfigPowHSMConfigwhich contains all the configuration handlers related to PowHSMPowpegNodeSystemPropertiespowpeg-nodeKEY_IDsuffix from elements inPowPegNodeKeyId