Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): replaces circleci w/ github workflow #275

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

jurajpiar
Copy link
Member

@jurajpiar jurajpiar commented Jun 17, 2024

Solves CORE-5765 by removing the CircleCI configuration and migrating it to GHA workflow one.
The sonarqube required some additions to the build.gradle file.

Important

Just before merging this PR we should remove the CircleCI integration in the repo settings @rsksmart/security.

Warning

@rsksmart/security We might want to consider shortening the default artefact storage period globally for this repo, as we only need them stored for the execution. See retention-days input for more info. Unless you'd prefer for me to use this param locally for each artefact?

@jurajpiar jurajpiar requested a review from a team June 17, 2024 22:25
@jurajpiar jurajpiar force-pushed the juraj/circleci_to_github_workflow branch 29 times, most recently from 49a9744 to cee3762 Compare June 20, 2024 10:41
jeremy-then
jeremy-then previously approved these changes Jul 24, 2024
Copy link
Contributor

@jeremy-then jeremy-then left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

nathanieliov
nathanieliov previously approved these changes Jul 29, 2024
Copy link
Contributor

@nathanieliov nathanieliov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fmacleal
fmacleal previously approved these changes Jul 29, 2024
@rmoreliovlabs rmoreliovlabs dismissed stale reviews from fmacleal and nathanieliov via d62f369 July 29, 2024 14:05
Copy link
Contributor

@lucasvuotto lucasvuotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bcodesido bcodesido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@diego-jeronymo diego-jeronymo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcos-iov marcos-iov force-pushed the juraj/circleci_to_github_workflow branch from 8d51c59 to 7bacb89 Compare July 31, 2024 15:23
Copy link

sonarcloud bot commented Jul 31, 2024

@marcos-iov
Copy link
Collaborator

pipeline:run

@marcos-iov marcos-iov merged commit f1f7825 into master Jul 31, 2024
7 of 8 checks passed
@marcos-iov marcos-iov deleted the juraj/circleci_to_github_workflow branch July 31, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants