-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): replaces circleci w/ github workflow #275
Conversation
49a9744
to
cee3762
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d62f369
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d62f369
to
bca4c55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8d51c59
to
7bacb89
Compare
Quality Gate passedIssues Measures |
pipeline:run |
Solves CORE-5765 by removing the CircleCI configuration and migrating it to GHA workflow one.
The sonarqube required some additions to the
build.gradle
file.Important
Just before merging this PR we should remove the CircleCI integration in the repo settings @rsksmart/security.
Warning
@rsksmart/security We might want to consider shortening the default artefact storage period globally for this repo, as we only need them stored for the execution. See retention-days input for more info. Unless you'd prefer for me to use this param locally for each artefact?