Skip to content

Commit

Permalink
extra tags should be optional
Browse files Browse the repository at this point in the history
Signed-off-by: vsoch <[email protected]>
  • Loading branch information
vsoch committed Mar 7, 2020
1 parent 13a2753 commit 555553c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Critical items to know are:
- changed behaviour (recipe sections work differently)

## [master](https://github.com/rseng/good-first-issues/tree/master)
- add issue label and collection folder parameters (v1.0.2)
- add issue label and collection folder parameters, extra tags optional (v1.0.2)
- ensure tags are sorted (v1.0.1)
- first tagged released associated with blog post (v1.0.0)

9 changes: 8 additions & 1 deletion scripts/generate-first-issues.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,14 @@

# Load repos
for line in lines:
repo, extra_tags = line.strip().split(" ")

# Extra tags are optional, separated by comma
extra_tags = ""
try:
repo, extra_tags = line.strip().split(" ")
except ValueError:
repo = line.strip()

extra_tags = extra_tags.split(",")
repo = "/".join(repo.split("/")[-2:])
url = api_base.format(repo=repo)
Expand Down

0 comments on commit 555553c

Please sign in to comment.