Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page icon #85

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-->
<title>ECMAScript 6: New Features: Overview and Comparison</title>
<link rel="icon" type="image/png" href="https://res.cloudinary.com/codeandpush/image/upload/c_scale,w_42/v1488836532/logo_es6_qncxsf.png"/>
<link rel="shortcut icon" type="image/png" href="https://res.cloudinary.com/codeandpush/image/upload/c_scale,w_42/v1488836532/logo_es6_qncxsf.png"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shortcut keyword is not be required, and ignored by modern browsers. See https://stackoverflow.com/a/13211460/1571491

<script src="lib/jquery/jquery.js" type="text/javascript"></script>
<script src="lib/director/director.js" type="text/javascript"></script>
<script src="lib/mousetrap/mousetrap.js" type="text/javascript"></script>
Expand Down