Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Angular 12 #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to Angular 12 #59

wants to merge 2 commits into from

Conversation

jsanta
Copy link

@jsanta jsanta commented May 25, 2021

Updates version to support Angular 12.
Just had to run:

  • npm install
  • npm audit fix
  • ng update @angular/core @angular/cli

jsanta added 2 commits May 25, 2021 16:05
@abadakhshan
Copy link

abadakhshan commented Jun 6, 2021

@jsanta
Why don't you transfer all dependencies to peerDependencies?
Wouldn't it be better to apply this instruction to move it to Ivy?

@jsanta
Copy link
Author

jsanta commented Jun 26, 2021

@jsanta
Why don't you transfer all dependencies to peerDependencies?
Wouldn't it be better to apply this instruction to move it to Ivy?

You're welcome to fork my fork and apply those changes (that's the beauty of open source you know) 🙂

@quanghd96
Copy link

Please support angular 12 soon

@abadakhshan
Copy link

@jsanta
Why don't you transfer all dependencies to peerDependencies?
Wouldn't it be better to apply this instruction to move it to Ivy?

You're welcome to fork my fork and apply those changes (that's the beauty of open source you know) 🙂

I Created this and use https://www.npmjs.com/package/@narik/custom-validators

@MickL
Copy link

MickL commented Nov 5, 2021

@rsaenen Could you please merge?
@abadakhshan Would you mind create a separate Github repo so we can work on and make PRs without this Narik thing? Further, I dont like that you take @rsaenen project and put your name in front. You renamed CustomFormsModule to NarikCustomValidatorsModule...

@abadakhshan
Copy link

abadakhshan commented Nov 5, 2021

@MickL
There isn't any dependency on other Narik modules, but you are right. If it is a separate repository it could be better for contributors. I will do it ASAP.

What is your point about Module's name?
I have noticed in Readme that it is a fork from @rsaenen repo.

@abadakhshan
Copy link

abadakhshan commented Nov 5, 2021

@MickL

I created a separate repo for it and publish version 7.0.1 to be compatible with Angular 13

https://github.com/NarikMe/narik-custom-validators

Copy link

@BianorAraujo BianorAraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants