Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ulens_model_fit.py #128

Closed
wants to merge 1 commit into from
Closed

Update ulens_model_fit.py #128

wants to merge 1 commit into from

Conversation

mjmroz
Copy link
Contributor

@mjmroz mjmroz commented Mar 15, 2024

Small changes in ex_16 to fix the problems that occur when adding extra parameters or fixing fluxes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.52%. Comparing base (fe4e532) to head (3cc0210).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   83.52%   83.52%           
=======================================
  Files          52       52           
  Lines        8318     8318           
=======================================
  Hits         6948     6948           
  Misses       1370     1370           
Flag Coverage Δ
unittests 83.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpoleski
Copy link
Owner

First two changes are taken from other branch.

Third change is an important one - Fitdata.source_fluxes should always be a np.array according to its docstring. This PR showed me that sometimes it is a list. The issue has to be fixed in fitdata.py, not here.

I don't fully understand the fourth change (blobs). Is it for cases with self._other_parameters defined? We should add proper printing of these other parameters in those cases.

@rpoleski
Copy link
Owner

Commit 970994c solved FitData.source_fluxes type.

@rpoleski
Copy link
Owner

rpoleski commented Apr 8, 2024

First few changes applied here: 6ca7435 (he master changed since PR was created).
The last change should not change anything, then it's not applied.

Thanks for these suggestions.

@rpoleski rpoleski closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants