fix: log on unsuccessful responses #45
Conversation
lib/graphql-hive/client.rb
Outdated
| def extract_error_details(response) | ||
| parsed_body = JSON.parse(response.body) | ||
| return unless parsed_body.is_a?(Hash) && parsed_body["errors"].is_a?(Array) | ||
| parsed_body["errors"].map { |error| "path: #{error["path"]}, message: #{error["message"]}" }.join(", ") |
There was a problem hiding this comment.
"path" is the location of the error within the JSON structure of the request.
for example, if there is an error in the metadata: client property, it will be
"path": "/operations/0/metadata/client"
There was a problem hiding this comment.
This looks great! Just wondering what the "error.message" looks like in the body? Just wondering if that is enough info to debug.
Knowing the field and reason would be huge though.
There was a problem hiding this comment.
it would look something like this, depending on the error:
lib/graphql-hive/client.rb
Outdated
| def extract_error_details(response) | ||
| parsed_body = JSON.parse(response.body) | ||
| return unless parsed_body.is_a?(Hash) && parsed_body["errors"].is_a?(Array) | ||
| parsed_body["errors"].map { |error| "path: #{error["path"]}, message: #{error["message"]}" }.join(", ") |
There was a problem hiding this comment.
This looks great! Just wondering what the "error.message" looks like in the body? Just wondering if that is enough info to debug.
Knowing the field and reason would be huge though.
Co-authored-by: Arya Bhimani <[email protected]>
|
Converted to draft, #46 first to fix bug in version 0.5.2 |
…raphql-ruby-hive into log-on-unsuccessful-responses
|
@rperryng this PR is ready to be merged! 🙏 |
Context
We want to add warning logs on client-level error responses.
Changes
>= 400 && < 500.Testing
Added unit tests
