fix: exclude invalid fields in analyzer #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidycodes
requested changes
Dec 3, 2024
cassidycodes
approved these changes
Dec 3, 2024
aryascripts
reviewed
Dec 3, 2024
cassidycodes
requested changes
Dec 3, 2024
lib/graphql-hive/client.rb
Outdated
Comment on lines
27
to
29
| if response.code.to_i >= 400 && response.code.to_i < 500 | ||
| @options[:logger].warn("Unsuccessful response: #{response.code} - #{response.body}") | ||
| end |
There was a problem hiding this comment.
Why did this get added to this PR? Are you certain response.body is safe to log without exposing tokens?
There was a problem hiding this comment.
its mostly for debugging purposes. to be safe, we can parse and log specific fields instead of the entire body. i'll remove this for now and address it in a separate PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When encountering invalid fields in a query, the analyzer would throw an error:
We want to handle these cases gracefully.
Changes
on_enter_fieldmethod in theGraphQL::Hive::Analyzerto validate both the parent type and the field existence before adding to@used_fields.Testing