add: slot-to-blocktime index + gsfa: store OffsetAndSizeAndSlot instead of OffsetAndSizeAndBlocktime
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagliardetto
changed the title
OffsetAndSizeAndSlot instead of OffsetAndSizeAndBlocktime
gagliardetto
changed the title
OffsetAndSizeAndSlot instead of OffsetAndSizeAndBlocktimeOffsetAndSizeAndSlot instead of OffsetAndSizeAndBlocktime
|
One last thing: should gsfa also contain whether the tx was successful or not? |
So right now for the stream transactions we parse it out from the error. Don't think we need it in gsfa. |
anjor
approved these changes
Dec 12, 2024
linuskendall
approved these changes
Dec 16, 2024
|
by having the success/fail in the gsfa index, we would avoid about 90% of io and cpu time (fetch tx, maybe fetch meta, parse meta) |
|
that makes sense. let's add it then. |
|
@gagliardetto i am going to merge it. Let's add the success/fail to gsfa index in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.