Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort car urls #172

Merged
merged 12 commits into from
Oct 26, 2024
Merged

sort car urls #172

merged 12 commits into from
Oct 26, 2024

Conversation

anjor
Copy link
Contributor

@anjor anjor commented Oct 16, 2024

for #169

@anjor anjor requested a review from gagliardetto October 16, 2024 13:40
gagliardetto
gagliardetto requested changes Oct 17, 2024
View reviewed changes
cmd-car-split.go Outdated Show resolved Hide resolved
linuskendall
linuskendall reviewed Oct 17, 2024
View reviewed changes
cmd-car-split.go Outdated Show resolved Hide resolved
gagliardetto
gagliardetto requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@gagliardetto gagliardetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a test with unsorted cars (with a test http server, test split car files, etc)

gagliardetto
gagliardetto reviewed Oct 23, 2024
View reviewed changes
cmd-car-split.go

endOffset := getEndOffset(fileSize)

partialContent, err := fetchFromOffset(url, endOffset)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check error

cmd-car-split_test.go Outdated Show resolved Hide resolved
@anjor anjor merged commit 8847406 into main Oct 26, 2024
1 check passed
@anjor anjor deleted the anjor/sort-car-urls branch October 26, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linuskendall linuskendall linuskendall left review comments

@gagliardetto gagliardetto gagliardetto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anjor @linuskendall @gagliardetto